[
https://issues.apache.org/jira/browse/FLINK-13497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16896773#comment-16896773
]
vinoyang commented on FLINK-13497:
----------------------------------
[~yunta] I have no objection to stopping the checkpoint scheduler. I just
explained that calling {{CheckpointCoordinator#stopCheckpointScheduler}}
directly is not a good choice in the long run. I am just wondering if we need a
pure cleanup mechanism that doesn't involve counting. Because it indirectly
calls {{CheckpointFailureManager#handleCheckpointException}}. It will become
more complicated when we change the failure count logic in the future.
> Checkpoints can complete after CheckpointFailureManager fails job
> -----------------------------------------------------------------
>
> Key: FLINK-13497
> URL: https://issues.apache.org/jira/browse/FLINK-13497
> Project: Flink
> Issue Type: Bug
> Components: Runtime / Checkpointing
> Affects Versions: 1.9.0, 1.10.0
> Reporter: Till Rohrmann
> Priority: Critical
> Fix For: 1.9.0
>
>
> I think that we introduced with FLINK-12364 an inconsistency wrt to job
> termination a checkpointing. In FLINK-9900 it was discovered that checkpoints
> can complete even after the {{CheckpointFailureManager}} decided to fail a
> job. I think the expected behaviour should be that we fail all pending
> checkpoints once the {{CheckpointFailureManager}} decides to fail the job.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
