azagrebin commented on a change in pull request #9272: [FLINK-13435] Remove
ShuffleDescriptor.ReleaseType and make release semantics fixed per partition
type
URL: https://github.com/apache/flink/pull/9272#discussion_r309167194
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/shuffle/ShuffleEnvironment.java
##########
@@ -61,17 +60,14 @@
* <li>{@link ResultPartitionWriter#fail(Throwable)} and {@link
ResultPartitionWriter#close()} are called
* if the production has failed.
* </li>
- * <li>if {@link
ResultPartitionDeploymentDescriptor#isReleasedOnConsumption()} is {@code true}
and
- * {@link ResultPartitionWriter#finish()} and {@link
ResultPartitionWriter#close()} are called when the production is done.
- * The actual release can take some time depending on implementation
details,
- * e.g. if the `end of consumption' confirmation from the consumer is
being awaited implicitly.
- * The partition has to support the {@link ReleaseType#AUTO} in {@link
ShuffleDescriptor#getSupportedReleaseTypes()}.</li>
- * <li>if {@link
ResultPartitionDeploymentDescriptor#isReleasedOnConsumption()} is {@code false}
and
- * {@link ShuffleMaster#releasePartitionExternally(ShuffleDescriptor)} and
{@link ShuffleEnvironment#releasePartitionsLocally(Collection)},
- * if it occupies any producer local resources ({@link
ShuffleDescriptor#storesLocalResourcesOn()}),
- * are called outside of the producer thread, e.g. to manage the lifecycle
of BLOCKING result partitions
- * which can outlive their producers. The partition has to support the
{@link ReleaseType#MANUAL} in
- * {@link ShuffleDescriptor#getSupportedReleaseTypes()}.</li>
+ * <li>for bounded pipelined partitions if the production is done ({@link
ResultPartitionWriter#finish()} and
Review comment:
I will rephrase it a bit, I meant that basically only bounded pipelined can
be ever done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
