tillrohrmann commented on a change in pull request #9268: [FLINK-13452] Ensure
to fail global when exception happens during reseting tasks of regions
URL: https://github.com/apache/flink/pull/9268#discussion_r309187098
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/failover/AdaptedRestartPipelinedRegionStrategyNG.java
##########
@@ -108,8 +106,7 @@ protected void restartTasks(final Set<ExecutionVertexID>
verticesToRestart) {
FutureUtils.assertNoException(
cancelTasks(verticesToRestart)
-
.thenRunAsync(resetAndRescheduleTasks(globalModVersion, vertexVersions),
executionGraph.getJobMasterMainThreadExecutor())
- .handle(failGlobalOnError()));
Review comment:
I think we should not change this logic since `cancelTasks` can return an
exceptionally completed future which would now cause the process to terminate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
