twalthr commented on a change in pull request #9243: [FLINK-13335][sql-parser] Align the SQL CREATE TABLE DDL with FLIP-37 URL: https://github.com/apache/flink/pull/9243#discussion_r309173413
########## File path: flink-table/flink-sql-parser/src/main/java/org/apache/flink/sql/parser/FlinkSqlDataTypeSpec.java ########## @@ -0,0 +1,325 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.sql.parser; + +import org.apache.flink.sql.parser.type.ExtendedSqlType; +import org.apache.flink.sql.parser.type.SqlArrayType; +import org.apache.flink.sql.parser.type.SqlBytesType; +import org.apache.flink.sql.parser.type.SqlMapType; +import org.apache.flink.sql.parser.type.SqlMultiSetType; +import org.apache.flink.sql.parser.type.SqlRowType; +import org.apache.flink.sql.parser.type.SqlStringType; +import org.apache.flink.sql.parser.type.SqlZonedTimeType; +import org.apache.flink.sql.parser.type.SqlZonedTimestampType; + +import org.apache.calcite.rel.type.RelDataType; +import org.apache.calcite.rel.type.RelDataTypeFactory; +import org.apache.calcite.sql.SqlCollation; +import org.apache.calcite.sql.SqlDataTypeSpec; +import org.apache.calcite.sql.SqlIdentifier; +import org.apache.calcite.sql.SqlNode; +import org.apache.calcite.sql.SqlUtil; +import org.apache.calcite.sql.SqlWriter; +import org.apache.calcite.sql.parser.SqlParserPos; +import org.apache.calcite.sql.type.SqlTypeName; +import org.apache.calcite.sql.type.SqlTypeUtil; +import org.apache.calcite.util.Util; + +import java.nio.charset.Charset; +import java.util.Objects; +import java.util.TimeZone; +import java.util.stream.Collectors; + +/** + * Represents a SQL data type specification in a parse tree. + * + * <p>A <code>SqlDataTypeSpec</code> is immutable; once created, you cannot + * change any of the fields.</p> + * + * <p>This class is an extension to {@link SqlDataTypeSpec}, we support + * complex type expressions like:</p> + * + * <blockquote><code>ROW(<br> + * NUMBER(5, 2) NOT NULL AS foo,<br> + * ROW(BOOLEAN AS b, MyUDT NOT NULL AS i) AS rec)</code></blockquote> + * + * <p>Until <a href="https://issues.apache.org/jira/browse/CALCITE-3213";>CALCITE-3213</a> + * is resolved, we can remove this class. + */ +public class FlinkSqlDataTypeSpec extends SqlDataTypeSpec { + // Flag saying if the element type is nullable if this type is a collection type. + // For collection type, we mean ARRAY and MULTISET type now. Review comment: and what about maps? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
