pnowojski commented on issue #9221: [FLINK-13376][datastream] ContinuousFileReaderOperator should respect… URL: https://github.com/apache/flink/pull/9221#issuecomment-516852415 Thanks for the explanation @ifndef-SleePy. I was asking because I noticed the build failures and I was wandering whether I've missed something during the reviews. > One more question, what's your opinion of the way of addressing review comments since the new code style guide? Shall I do the squashing myself or just append some hotfix commits? Appending comments could keep the review history but leaves the squashing step to reviewer. There is no clear policy in this regard. I personally, as a contributor when I submit my PRs, I usually squash the fixup commits immediately, so usually I do not publish fixup commits in the PR. Where **usually** means if the fixup is trivial, didn't touch new code, etc. Sometimes I publish fixup commit (that should be squashed before merging) if it contained something not trivial. I know that others contributors/committers have different practises in this regard (some of them are always publishing fixup commits and squash them only at the end). As a reviewer I very rarely manually checkout the PR, so I usually ask the contributor to squash the appropriate commits together before I merge something (again, exception to this rule if the end state of the PR should be just a single commit, in that case I can squash them from the github ui with a click of one button, so I do not have to ask contributor to that ;) ). Can you let me know once the travis is green?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
