azagrebin commented on a change in pull request #9250:
[FLINK-13371][coordination] Prevent leaks of blocking partitions
URL: https://github.com/apache/flink/pull/9250#discussion_r309220898
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/executiongraph/Execution.java
##########
@@ -1206,7 +1213,12 @@ private boolean processFail(Throwable t, boolean
isCallback, Map<String, Accumul
releaseAssignedResource(t);
vertex.getExecutionGraph().deregisterExecution(this);
- stopTrackingAndReleasePartitions();
+ if (releasePartitions) {
+
sendReleaseIntermediateResultPartitionsRpcCall();
+ stopTrackingAndReleasePartitions();
+ } else {
+ stopTrackingPartitions();
Review comment:
looks like we can push this into e.g. `stopTrackingPartitions` if
`stopTrackingPartitions ` also had `releasePartitions` parameter, then
`stopTrackingPartitions `, `stopTrackingAndReleasePartitions ` and
`getPartitionIds ` could be merged into one function
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
