GJL commented on a change in pull request #9271: [FLINK-13384][1.9][runtime]
Fix back pressure sampling for SourceStreamTask
URL: https://github.com/apache/flink/pull/9271#discussion_r309272098
##########
File path:
flink-runtime/src/test/java/org/apache/flink/runtime/taskmanager/TaskTest.java
##########
@@ -922,6 +926,40 @@ public void
testTerminationFutureCompletesOnErrorInInvoke() throws Exception {
assertEquals(ExecutionState.FAILED,
task.getTerminationFuture().getNow(null));
}
+ @Test
Review comment:
> Either instead of those unit tests or additionally to them [...]
I decided to drop the unit tests here except for
`testReturnsEmptyStackTraceIfTaskNotStarted` because
- there was a race condition in `testReturnsStackTraceOfTaskExecutingThread`
and `testReturnsStackTraceOfAbstractInvokableExecutingThread`
- they are covered by `BackPressureITCase`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
