zhijiangW commented on issue #9272: [FLINK-13435] Remove ShuffleDescriptor.ReleaseType and make release semantics fixed per partition type URL: https://github.com/apache/flink/pull/9272#issuecomment-516995246 Thanks for the updates @azagrebin ! Almost LGTM on my side, only confirm one thing before merging: I thought `FORCE_PARTITION_RELEASE_ON_CONSUMPTION` only suitable for pipelined partitions. If we make this option true for blocking partitions, then the partition release should be still controlled by JM always. If so, do we need to avoid generate `ReleaseOnConsumptionResultPartition` for blocking partitions in `ResultPartitionFactory`? In current implementation, the `ReleaseOnConsumptionResultPartition` would be constructed if `forcePartitionReleaseOnConsumption || !type.isBlocking()`. I wonder the blocking partition release controlled by `ReleaseOnConsumptionResultPartition` might cause some problem because of FLINK-13493.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
