lirui-apache commented on a change in pull request #9310: [FLINK-13190]add test
to verify partition pruning for HiveTableSource
URL: https://github.com/apache/flink/pull/9310#discussion_r309547228
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/batch/connectors/hive/HiveTableSource.java
##########
@@ -67,13 +67,15 @@
private List<Map<String, String>> partitionList = new ArrayList<>();
private Map<Map<String, String>, HiveTablePartition>
partitionSpec2HiveTablePartition = new HashMap<>();
private boolean initAllPartitions;
+ private boolean applyPartitionPrunning;
Review comment:
I'm a little confused about the name of this field. Is it about "whether we
should apply partition pruning", or "whether partition pruning has been
applied"? If it's the latter, I think we can rename it to something like
`partitionPruned`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
