azagrebin commented on issue #9272: [FLINK-13435] Remove ShuffleDescriptor.ReleaseType and make release semantics fixed per partition type URL: https://github.com/apache/flink/pull/9272#issuecomment-517207789 Thanks for the review @zhijiangW ! I mentioned the explanation in FLINK-13493. `forcePartitionReleaseOnConsumption` is just a safety net to fallback to the old 1.8 behaviour and should not be used for 1.9 in general. JM does not use this option and always tries to take care about release (as you mentioned it should be always the case) so `forcePartitionReleaseOnConsumption` will just enforce/speed up release in certain cases and degrade fine-grained recovery. In future, we can remove `forcePartitionReleaseOnConsumption` at all and rely only on JM.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
