zjuwangg commented on issue #9310: [FLINK-13190]add test to verify partition pruning for HiveTableSource URL: https://github.com/apache/flink/pull/9310#issuecomment-517219228 Hi @lirui-apache @xuefuz ~ I studied the way of the planner `org.apache.flink.table.planner.plan.rules.logical.PushFilterIntoTableSourceScanRuleTest` test, and found it use xml file to record the expected file and compare with the produced plan. It's a little heavy to adapt this method to our case. I refactor `HiveTableSource#testPartitionPrune` to reduce the possibility of broken by outside change. We may discuss this topic offline further.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
