JingsongLi commented on issue #9312: [FLINK-13436][end-to-end-tests] Add TPC-H queries as E2E tests URL: https://github.com/apache/flink/pull/9312#issuecomment-517239082 > Very nice PR @TsReaper. I just had minor comments. One question that I have is how do we ensure that the result verification is correct. Have you also manually tried to execute some queries in a popular system such as Oracle or Hive and compared it against Flink's results. I would just like to be on the safe side. The library has its result: https://github.com/airlift/tpch/tree/master/src/main/resources/io/airlift/tpch/queries Whatever the scale factor, the output is the same. Now, we just compare with its result. I think its result is come from presto. And I agree with execute some queries in a popular system. TPCH document also define some sample output for validation, (Like 2.4.1.4 in http://www.tpc.org/tpc_documents_current_versions/pdf/tpc-h_v2.18.0.pdf). But maybe it requires 1 scale factor at least.
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
