[ 
https://issues.apache.org/jira/browse/FLINK-13525?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898067#comment-16898067
 ] 

Jark Wu commented on FLINK-13525:
---------------------------------

Sure. 

> Improve Expression validation test
> ----------------------------------
>
>                 Key: FLINK-13525
>                 URL: https://issues.apache.org/jira/browse/FLINK-13525
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table SQL / Planner
>            Reporter: Jark Wu
>            Priority: Minor
>             Fix For: 1.10.0
>
>
> Currently, the expression validation tests under 
> {{org.apache.flink.table.expressions.validation}} are using following pattern 
> to verify an exception should be thrown:
> {code:scala}
> @Test
>   def testWrongKeyType(): Unit = {
>     testAllApis('f2.at(12), "f2.at(12)", "f2[12]", "FAIL")
>   }
> {code}
> However, this only covers the first expression {{'f2.at(12)}} throw the 
> expected exception. All the other expression will be ignored. We should 
> improve this. And it's nice to test the expected exception message too.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to