[
https://issues.apache.org/jira/browse/FLINK-2775?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14934847#comment-14934847
]
ASF GitHub Bot commented on FLINK-2775:
---------------------------------------
Github user zentol commented on a diff in the pull request:
https://github.com/apache/flink/pull/1189#discussion_r40646129
--- Diff:
flink-staging/flink-streaming/flink-streaming-core/src/main/java/org/apache/flink/streaming/util/ClusterUtil.java
---
@@ -26,11 +26,17 @@
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;
-
-public class ClusterUtil {
+/**
+ * Utility class to manage mini cluster for Apache Flink.
+ */
+public final class ClusterUtil {
private static final Logger LOG =
LoggerFactory.getLogger(ClusterUtil.class);
+ private ClusterUtil() {
+ // Prevent instantiation.
--- End diff --
no javadoc, doesn't throw a runtime exception as other constructors.
> [CLEANUP] Cleanup code as part of theme to be more consistent on Utils classes
> ------------------------------------------------------------------------------
>
> Key: FLINK-2775
> URL: https://issues.apache.org/jira/browse/FLINK-2775
> Project: Flink
> Issue Type: Improvement
> Reporter: Henry Saputra
> Assignee: Henry Saputra
> Priority: Minor
>
> As part of the theme to help make the code more consistent, add cleanup to
> Utils classes:
> -) Add final class modifier to the XXXUtils and XXXUtil classes to make sure
> can not be extended.
> -) Add missing Javadoc header classs to some public classes.
> -) Add private constructor to Utils classes to avoid instantiation.
> -) Remove unused
> test/java/org/apache/flink/test/recordJobs/util/ConfigUtils.java class
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
