twalthr commented on a change in pull request #9313:  [FLINK-13504][table] 
Fixed shading issues in table modules. 
URL: https://github.com/apache/flink/pull/9313#discussion_r309748868
 
 

 ##########
 File path: flink-table/flink-table-uber/pom.xml
 ##########
 @@ -96,8 +95,8 @@ under the License.
                                                <configuration>
                                                        <artifactSet>
                                                                <includes 
combine.children="append">
+                                                                       <!--Sql 
parser is included in planners-->
 
 Review comment:
   Does it harm to include it here as well? Because you could also argue that 
`flink-table-api-java` is in `flink-table-api-scala` etc.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to