wuchong commented on a change in pull request #9310: [FLINK-13190]add test to
verify partition pruning for HiveTableSource
URL: https://github.com/apache/flink/pull/9310#discussion_r310005093
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableSource.java
##########
@@ -223,4 +226,10 @@ private Object restorePartitionValueFromFromType(String
valStr, DataType type) {
throw new FlinkHiveException(
new IllegalArgumentException(String.format("Can
not convert %s to type %s for partition value", valStr, type)));
}
+
+ @Override
+ public String explainSource() {
+ return super.explainSource() + String.format(" PartitionPruned:
%s, partitionNums: %d",
Review comment:
Oh, just find the comment. +1 to add db/table name.
But I'm fine if we add it later. It doesn't break the correctness.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
