twalthr commented on a change in pull request #9333: [FLINK-9782][e2e] Harden 
bucketing sink e2e test.
URL: https://github.com/apache/flink/pull/9333#discussion_r310017538
 
 

 ##########
 File path: 
flink-end-to-end-tests/flink-bucketing-sink-test/src/main/java/org/apache/flink/streaming/tests/BucketingSinkTestProgram.java
 ##########
 @@ -143,6 +147,7 @@ public void open(Configuration parameters) {
                private final int durationMs;
 
                private long ms = 0;
+               private volatile boolean canceled = false;
 
 Review comment:
   Is the volatile really necessary? I thought every task is single threaded?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to