beyond1920 commented on a change in pull request #9335: [FLINK-13503][API] Add 
contract in `LookupableTableSource` to specify the behavior when lookupKeys 
contains null.
URL: https://github.com/apache/flink/pull/9335#discussion_r310073549
 
 

 ##########
 File path: 
flink-table/flink-table-common/src/main/java/org/apache/flink/table/sources/LookupableTableSource.java
 ##########
 @@ -34,12 +34,29 @@
 
        /**
         * Gets the {@link TableFunction} which supports lookup one key at a 
time.
+        *
         * @param lookupKeys the chosen field names as lookup keys, it is in 
the defined order
+        *
+        * <p>IMPORTANT:
+        * If the returned {@link TableFunction} receives a lookup request with 
null value in lookup keys, expect
 
 Review comment:
   OK, I'll try to explain more clearly in the comment

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to