[ 
https://issues.apache.org/jira/browse/FLINK-13188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16898816#comment-16898816
 ] 

Chesnay Schepler edited comment on FLINK-13188 at 8/2/19 11:38 AM:
-------------------------------------------------------------------

So this issue is valid. When enabling assertions, and configuring IntelliJ to 
introduce additional assertions for nonnull/nullable annotations, then the 
MockStateTtlTests are failing consistently since the 
{{CheckpointStreamFactory}} contained in the {{CheckpointStorage}} returned by 
the {{MockStateBackend}} is always null, which is passed to 
{{SnapshotStrategy#snapshot}}, but it is annotated with Nonnull.


was (Author: zentol):
So this issue is valid. When enabling assertions, and configuring IntelliJ to 
introduce additional assertions for nonnull/nullable annotations, then the 
MockStateTtlTests are failing consistently since the 
{{CheckpointStreamFactory}} contained in the {{CheckpointStorage}} returned by 
the {{MockStateBackend}} is always null, which is passed to 
{{SnapshotStrategy#snapshot}}, but it is annotated with Nonnull.

As such the {{MockStateBackend}} does not conform the constraints defined by 
the {{SnapshotStrategy}} interface.

> MockStateBackend usage in MockStateTtlTest violates Nonnull annotations
> -----------------------------------------------------------------------
>
>                 Key: FLINK-13188
>                 URL: https://issues.apache.org/jira/browse/FLINK-13188
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / State Backends
>    Affects Versions: 1.7.2, 1.8.0, 1.8.1, 1.9.0
>         Environment: system: ubuntu16.04
> ide: intellij 2018.1.8
>            Reporter: Lun Zhang
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 1.9.0
>
>         Attachments: 
> addRuntimeAssertionsForNotNullAnnototatedMethodsAndParameters.png, error.png
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> 94 tests failed when running the tests of *flink-runtime/state/ttl* with 
> intellij run time assertions opening.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to