becketqin commented on issue #8631: [FLINK-12745][ml] add sparse and dense vector class, and dense matrix class with basic operations. URL: https://github.com/apache/flink/pull/8631#issuecomment-517703789 @xuyang1706 Thanks for updating the patch. I created a PR against your branch to provide some suggestions. Besides that, it seems that the unit tests coverage of the matrix and vector calculation is not super complete. Do you have plan to add more unit tests?
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
