lirui-apache commented on a change in pull request #9264: [FLINK-13192][hive]
Add tests for different Hive table formats
URL: https://github.com/apache/flink/pull/9264#discussion_r310340281
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/connectors/hive/HiveTableOutputFormat.java
##########
@@ -124,7 +124,7 @@
private transient int numNonPartitionColumns;
// SerDe in Hive-1.2.1 and Hive-2.3.4 can be of different classes, make
sure to use a common base class
- private transient Serializer serializer;
+ private transient Serializer recordSerDe;
Review comment:
It has to be a serializer because we need it to serialize records. Besides,
using Object means we have to use reflection to call the `serialize` method.
And if we do this for each record, it might hurt performance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
