godfreyhe opened a new pull request #9349: [FLINK-13564] [table-planner-blink] 
throw exception if constant with YEAR TO MONTH resolution was used for group 
windows
URL: https://github.com/apache/flink/pull/9349
 
 
   
   
   ## What is the purpose of the change
   
   *Checking if a proper resolution was used for group window parameter. 
Without this check INTERVAL '2-10' YEAR TO MONTH would be a valid window size 
that would be translated to 34 milliseconds window.*
   
   
   ## Brief change log
   
     - *add check in StreamLogicalWindowAggregateRule*
   
   
   ## Verifying this change
   
   
org.apache.flink.table.planner.plan.stream.sql.agg.WindowAggregateTest#testWindowWrongWindowParameter
   
   
   ## Does this pull request potentially affect one of the following parts:
   
     - Dependencies (does it add or upgrade a dependency): (yes / **no**)
     - The public API, i.e., is any changed class annotated with 
`@Public(Evolving)`: (yes / **no**)
     - The serializers: (yes / **no** / don't know)
     - The runtime per-record code paths (performance sensitive): (yes / **no** 
/ don't know)
     - Anything that affects deployment or recovery: JobManager (and its 
components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know)
     - The S3 file system connector: (yes / **no** / don't know)
   
   ## Documentation
   
     - Does this pull request introduce a new feature? (yes / **no**)
     - If yes, how is the feature documented? (not applicable / docs / JavaDocs 
/ **not documented**)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to