[
https://issues.apache.org/jira/browse/FLINK-2766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14935350#comment-14935350
]
ASF GitHub Bot commented on FLINK-2766:
---------------------------------------
GitHub user StephanEwen opened a pull request:
https://github.com/apache/flink/pull/1192
[FLINK-2766] [core] Add proper handling for IPv6 literals in URLs
All URLs and literals of the form `host:port` are now handled through the
`NetUtils` class, which ensures that IPv6 address literals are properly handles
by putting them in square brackets:
`[2001:db8:10:11:12:ff00:42:8329]:1234` instead of
`2001:db8:10:11:12:ff00:42:8329:1234`
This builds on #1190
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/StephanEwen/incubator-flink ipv6_urls
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/1192.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1192
----
commit cc0ee16363c38990e04091725b53cf7b0565a0d2
Author: Stephan Ewen <[email protected]>
Date: 2015-09-29T14:36:04Z
[FLINK-2781] [core] Cleanup NetUtils.
- The NetUtils class (in flink-core) contains all methods usable without
runtime dependency
- The runtime NetUtils class (to find connectiong addresses) is now
called ConnectionUtil.
commit 550c4cc34b08e09c6840b4c2c285489e651f325e
Author: Stephan Ewen <[email protected]>
Date: 2015-09-29T15:45:06Z
[FLINK-2766] [core] Add proper handling of IPv6 address literals in URLs
----
> Bad ipv6 urls
> -------------
>
> Key: FLINK-2766
> URL: https://issues.apache.org/jira/browse/FLINK-2766
> Project: Flink
> Issue Type: Bug
> Affects Versions: 0.9.1, 0.9.2
> Reporter: Arsenii Krasikov
> Assignee: Stephan Ewen
> Priority: Blocker
>
> There is error with ipv6 addresses in
> flink-runtime/src/main/scala/org/apache/flink/runtime/jobmanager/JobManager.scala:
> {code:java}
> /**
> * Builds the akka actor path for the JobManager actor, given the socket
> address
> * where the JobManager's actor system runs.
> *
> * @param address The address of the JobManager's actor system.
> * @return The akka URL of the JobManager actor.
> */
> def getRemoteJobManagerAkkaURL(address: InetSocketAddress): String = {
> val hostPort = address.getAddress().getHostAddress() + ":" +
> address.getPort()
> s"akka.tcp://flink@$hostPort/user/$JOB_MANAGER_NAME"
> }
> {code}
> that leads to
> {code}
> 19:02:10,451 INFO org.apache.flink.runtime.taskmanager.TaskManager
> - Trying to register at JobManager
> akka.tcp://flink@2a02:6b8:0:1a39:0:0:12c:1:6123/user/jobmanager (attempt 31,
> timeout: 30 seconds)
> 19:02:40,470 INFO org.apache.flink.runtime.taskmanager.TaskManager
> - Trying to register at JobManager
> akka.tcp://flink@2a02:6b8:0:1a39:0:0:12c:1:6123/user/jobmanager (attempt 32,
> timeout: 30 seconds)
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
