xuefuz commented on a change in pull request #9342: [FLINK-13438][hive] Fix 
DataTypes.DATE/TIME/TIMESTAMP support for hive connectors
URL: https://github.com/apache/flink/pull/9342#discussion_r310791338
 
 

 ##########
 File path: 
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTableUtil.java
 ##########
 @@ -133,4 +140,34 @@ public static Partition createHivePartition(String 
dbName, String tableName, Lis
                return partition;
        }
 
+       public static CatalogTable toHiveCatalogTable(CatalogTable oldTable) {
 
 Review comment:
   +1, I think we should just convert the old table's TableSchema to a new 
TableSchema by changing the corresponding field types. This does more than what 
we need.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to