twalthr commented on a change in pull request #9354: [FLINK-13568][sqk-parser]
DDL create table doesn't allow STRING data …
URL: https://github.com/apache/flink/pull/9354#discussion_r310924831
##########
File path:
flink-table/flink-sql-parser/src/test/java/org/apache/flink/sql/parser/FlinkSqlParserImplTest.java
##########
@@ -365,18 +365,18 @@ public void
testCreateTableWithWatermarkStrategyFromSource() {
public void testCreateTableWithComplexType() {
check("CREATE TABLE tbl1 (\n" +
Review comment:
I agree with Xuefu. All we need is actually one test
`testCreateTableWithAllTypes` we could improve `testCreateTableWithComplexType`
for that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
