dianfu commented on a change in pull request #9370: [FLINK-13594][python]
Improve the 'from_element' method of flink python api to apply to blink planner
URL: https://github.com/apache/flink/pull/9370#discussion_r310956719
##########
File path: flink-python/pyflink/table/table_environment.py
##########
@@ -800,14 +806,20 @@ def _from_file(self, filename, schema):
gateway = get_gateway()
blink_t_env_class = get_java_class(
gateway.jvm.org.apache.flink.table.api.internal.TableEnvironmentImpl)
- if blink_t_env_class == self._j_tenv.getClass():
- raise NotImplementedError("The operation 'from_elements' in batch
mode is currently "
- "not supported when using blink
planner.")
+ is_blink = (blink_t_env_class == self._j_tenv.getClass())
+ row_type_info = _to_java_type(schema)
+ if is_blink:
+ execution_config =
gateway.jvm.org.apache.flink.api.common.ExecutionConfig()
Review comment:
Could you add some comments describing why the blink planner should be
processed differently?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
