1u0 commented on a change in pull request #9318: [FLINK-13044][s3][fs] Fix handling of relocated amazon classes URL: https://github.com/apache/flink/pull/9318#discussion_r311028550
########## File path: tools/travis/splits/split_misc.sh ########## @@ -76,5 +76,7 @@ run_test "SQL Client end-to-end test for modern Kafka" "$END_TO_END_DIR/test-scr run_test "Dependency shading of table modules test" "$END_TO_END_DIR/test-scripts/test_table_shaded_dependencies.sh" +run_test "Shaded Hadoop S3A with credentials provider end-to-end test" "$END_TO_END_DIR/test-scripts/test_batch_wordcount.sh hadoop_with_provider" Review comment: Unrelated to the changes in this PR, but could you also move: ``` run_test "Shaded Hadoop S3A end-to-end test" "$END_TO_END_DIR/test-scripts/test_batch_wordcount.sh hadoop" run_test "Shaded Presto S3 end-to-end test" "$END_TO_END_DIR/test-scripts/test_batch_wordcount.sh presto" ``` from `run-pre-commit-tests.sh` to here, so they are aggregated in one place? Apparently, the above tests are not actually running during pre-commit tests run: ``` ============================================================================== Running 'Shaded Hadoop S3A end-to-end test' ============================================================================== ... Did not find AWS environment variables, NOT running the e2e test. ... [PASS] 'Shaded Hadoop S3A end-to-end test' passed after 0 minutes and 0 seconds! Test exited with exit code 0. ============================================================================== Running 'Shaded Presto S3 end-to-end test' ============================================================================== ... Did not find AWS environment variables, NOT running the e2e test. ... [PASS] 'Shaded Presto S3 end-to-end test' passed after 0 minutes and 0 seconds! Test exited with exit code 0. ``` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
