dawidwys commented on a change in pull request #9368: [FLINK-13592][e2e] Fix hardcoded flink version in tpch end-to-end test. URL: https://github.com/apache/flink/pull/9368#discussion_r311041371
########## File path: flink-end-to-end-tests/test-scripts/test_tpch.sh ########## @@ -72,6 +74,7 @@ execution: planner: blink type: batch result-mode: table + parallelism: 2 Review comment: How is this related to the linked issue? Honestly I still don't get what is the purpose of this change. I disagree this is a good place to add such cases. It's impossible to link this change to the reason why it was introduced. I'm not saying we need a new JIRA issue, but it should at least be in a separate hotfix commit with at least brief explanation what it does. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
