carp84 commented on a change in pull request #9364:
[FLINK-13593][checkpointing] Prevent failing the wrong execution attempt in
CheckpointFailureManager
URL: https://github.com/apache/flink/pull/9364#discussion_r311260993
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/checkpoint/CheckpointFailureManager.java
##########
@@ -151,7 +170,13 @@ private static boolean isPreFlightFailure(final Throwable
cause) {
*/
public interface FailJobCallback {
- void failJob(final Throwable cause);
+ /**
+ * Fails the whole job graph.
+ *
+ * @param cause The reason why the job is cancelled.
+ * @param failingAttempt The failing attempt id to prevent
failing the wrong job.
+ */
+ void failJob(final Throwable cause, @Nullable final
ExecutionAttemptID failingAttempt);
Review comment:
I'm afraid we cannot since there're cases like exception thrown when
`triggerCheckpoint`, as well as the legacy `handleSynchronousSavepointFailure`
method in `CheckpointFailureManager`, which are not caused by a single task
failure. Will add a default interface to overload this method.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
