tzulitai commented on issue #9375: [FLINK-13159] Prevent potential NPE of 
restored PojoSerializer when deserializing
URL: https://github.com/apache/flink/pull/9375#issuecomment-519026582
 
 
   @Myasuka thanks for the fast fix.
   As discussed offline, I've reverted the changes to `SerializerTestBase` 
since the requirement of equality checks on the test data objects is out of 
scope of this fix, and would require a more proper discussion on how we want to 
do that.
   
   On top of your fixes, I've extended the `PojoSerializerMigrationTest` to 
cover the NPE case.
   Those tests fail without your fix, so that should confirm that the fix is 
correct.
   
   Will merge once Travis is green:
   https://github.com/tzulitai/flink/tree/FLINK-13159-premerge

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to