dawidwys opened a new pull request #9380: [FLINK-13630][table-api-bridge] Use values retention configuration from TableConfig if not specified explicitly URL: https://github.com/apache/flink/pull/9380 ## What is the purpose of the change In a sequence like this: ``` tEnv.getConfig().setIdleStateRetentionTime(minRetention, maxRetention); Table table = tEnv.fromDataStream(elements); tEnv.toAppendStream(table, Row.class); ``` the call to toAppendStream will override the value set in tEnv.getConfig.setIdleStateRetentionTime. I think we should change that behavior, as we want to drop the version with explicit QueryConfig and recommend the described setup. ## Brief change log If methods that do not specify QueryConfig explicitly are used in StreamTableEnvironment than the values from TableConfig will be used. If methods that accept QueryConfig are used than those values will be used to overwrite the TableConfig. ## Verifying this change This change added tests: * org.apache.flink.table.api.java.internal.StreamTableEnvironmentImplTest * org.apache.flink.table.api.scala.internal.StreamTableEnvironmentImplTest ## Does this pull request potentially affect one of the following parts: - Dependencies (does it add or upgrade a dependency): (yes / **no**) - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (yes / **no**) - The serializers: (yes / **no /** don't know) - The runtime per-record code paths (performance sensitive): (yes / **no** / don't know) - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing, Yarn/Mesos, ZooKeeper: (yes / **no** / don't know) - The S3 file system connector: (yes / **no /** don't know) ## Documentation - Does this pull request introduce a new feature? (yes / **no**) - If yes, how is the feature documented? (not applicable / docs / **JavaDocs** / not documented)
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
