[
https://issues.apache.org/jira/browse/FLINK-2613?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14936926#comment-14936926
]
ASF GitHub Bot commented on FLINK-2613:
---------------------------------------
Github user chiwanpark commented on a diff in the pull request:
https://github.com/apache/flink/pull/1106#discussion_r40802535
--- Diff:
flink-staging/flink-scala-shell/src/test/scala/org/apache/flink/api/scala/ScalaShellITSuite.scala
---
@@ -225,6 +220,52 @@ class ScalaShellITSuite extends FunSuite with Matchers
with BeforeAndAfterAll {
out.toString + stdout
}
+ /**
+ * tests flink shell startup with remote cluster (starts cluster
internally)
+ */
+ test("start flink scala shell with remote cluster") {
+
+ val input: String = "val els = env.fromElements(\"a\",\"b\");\n" +
+ "els.print\nError\n:q\n"
+
+ val in: BufferedReader = new BufferedReader(
+ new StringReader(
+ input + "\n"))
+ val out: StringWriter = new StringWriter
+
+ val baos: ByteArrayOutputStream = new ByteArrayOutputStream
+ val oldOut: PrintStream = System.out
+ System.setOut(new PrintStream(baos))
+ val c = cluster.getOrElse(null);
+ var args : Array[String] = null;
+ if(c != null){
+ args = Array("remote",
+ c.hostname,
+ Integer.toString(c.getLeaderRPCPort))
+ }
+ else{
+ assert(false)
+ }
+
+ //start scala shell with initialized
+ // buffered reader for testing
+ FlinkShell.bufferedReader = in;
+ FlinkShell.main(args)
+ baos.flush
+
+ val output: String = baos.toString
+ System.setOut(oldOut)
+
+ assert(output.contains("Job execution switched to status FINISHED."))
+ assert(output.contains("a\nb"))
+
+ assert((!output.contains("Error")))
+ assert((!output.contains("ERROR")))
+ assert((!output.contains("Exception")))
+ assert((!output.contains("failed")))
--- End diff --
And scalatest matcher syntax would be better. For example:
```scala
output should not include "Error"
```
You can see statements like this at line 162-164 of
`ScalaShellITSuite.scala`.
> Print usage information for Scala Shell
> ---------------------------------------
>
> Key: FLINK-2613
> URL: https://issues.apache.org/jira/browse/FLINK-2613
> Project: Flink
> Issue Type: Improvement
> Components: Scala Shell
> Affects Versions: 0.10
> Reporter: Maximilian Michels
> Assignee: Nikolaas Steenbergen
> Priority: Minor
> Labels: starter
> Fix For: 0.10
>
>
> The Scala Shell startup script starts a {{FlinkMiniCluster}} by default if
> invoked with no arguments.
> We should add a {{--help}} or {{-h}} option to make it easier for people to
> find out how to configure remote execution. Alternatively, we could print a
> notice on the local startup explaining how to start the shell in remote mode.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
