wuchong commented on a change in pull request #9377:
[FLINK-13561][table-planner-blink] Verify and correct time function's semantic
for Blink planner
URL: https://github.com/apache/flink/pull/9377#discussion_r311827891
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/calls/ScalarOperatorGens.scala
##########
@@ -168,8 +168,15 @@ object ScalarOperatorGens {
generateBinaryArithmeticOperator(ctx, op, left.resultType, left, right)
case (DATE, INTERVAL_DAY_TIME) =>
- generateOperatorIfNotNull(ctx, new DateType(), left, right) {
- (l, r) => s"$l $op ((int) ($r / ${MILLIS_PER_DAY}L))"
+ resultType.getTypeRoot match {
Review comment:
It is in order to fix `timestampadd(hour, 1, date '2019-08-08')` which will
get `2019-08-08` as result before the change.
I'm sorry I messed it in `to_timestamp` commit. I should split it out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
