[
https://issues.apache.org/jira/browse/FLINK-13225?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16902788#comment-16902788
]
Timo Walther edited comment on FLINK-13225 at 8/8/19 8:41 AM:
--------------------------------------------------------------
I'm not sure if there was really consensus on having a temporary solution like
this. The PR was stale also because what it does is very hacky (as mentioned in
this
[PR|https://github.com/apache/flink/pull/8920#pullrequestreview-260727887]) and
not supported by others. It is true that the PR is already 1 month old but even
this date was officially after feature freeze. It enables Hive UDFs (which is
great!) but by avoiding the API and changing a couple of locations in the Blink
planner. All these changes are instant legacy. I'm fine with not reverting the
changes, because both Blink and Hive are considered more beta/experimental. But
in the future I would kindly remind everyone that "feature freeze" means
"feature freeze".
was (Author: twalthr):
I'm not sure if there was really consensus on having a temporary solution like
this. The PR was stale also because what it does is very hacky (as mentioned in
this [PR|https://github.com/apache/flink/pull/8920]) and not supported by
others. It is true that the PR is already 1 month old but even this date was
officially after feature freeze. It enables Hive UDFs (which is great!) but by
avoiding the API and changing a couple of locations in the Blink planner. All
these changes are instant legacy. I'm fine with not reverting the changes,
because both Blink and Hive are considered more beta/experimental. But in the
future I would kindly remind everyone that "feature freeze" means "feature
freeze".
> Introduce type inference for hive functions in blink
> -----------------------------------------------------
>
> Key: FLINK-13225
> URL: https://issues.apache.org/jira/browse/FLINK-13225
> Project: Flink
> Issue Type: Improvement
> Components: Table SQL / Planner
> Reporter: Jingsong Lee
> Assignee: Jingsong Lee
> Priority: Major
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> See some conversation in [https://github.com/apache/flink/pull/8920]
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
