zjuwangg commented on a change in pull request #9342: [FLINK-13438][hive] Fix
DataTypes.DATE/TIME/TIMESTAMP support for hive connectors
URL: https://github.com/apache/flink/pull/9342#discussion_r311934058
##########
File path:
flink-connectors/flink-connector-hive/src/test/java/org/apache/flink/connectors/hive/TableEnvHiveConnectorTest.java
##########
@@ -138,6 +158,74 @@ private void readWriteFormat(String format) throws
Exception {
hiveShell.execute("drop database db1 cascade");
}
+ @Test
+ public void testHiveSourceSink() throws Exception {
+ // this test is to check whether data can successfully
+ // flow from hive source into flink system and then into hive
sink.
+ // we especially want to test data types about time here.
Review comment:
Test comments should appeare before the method definition.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
