JingsongLi commented on a change in pull request #9342: [FLINK-13438][hive] Fix
DataTypes.DATE/TIME/TIMESTAMP support for hive connectors
URL: https://github.com/apache/flink/pull/9342#discussion_r312007775
##########
File path:
flink-connectors/flink-connector-hive/src/main/java/org/apache/flink/table/catalog/hive/util/HiveTypeUtil.java
##########
@@ -256,9 +258,9 @@ private static DataType
toFlinkPrimitiveType(PrimitiveTypeInfo hiveType) {
case DOUBLE:
return DataTypes.DOUBLE();
case DATE:
- return DataTypes.DATE();
+ return DataTypes.DATE().bridgedTo(Date.class);
case TIMESTAMP:
- return DataTypes.TIMESTAMP();
+ return
DataTypes.TIMESTAMP(3).bridgedTo(Timestamp.class);
Review comment:
+1 to keep precision and throw exception.
Indeed there are somewhere to loss precision because of conversion between
TypeInformation and DataType. But we do our best to use DataType and keep
precision. And we just convert the timestamp with precision smaller than 3.
(`LegacyTypeInfoDataTypeConverter.canConvertToTimestampTypeInfoLenient`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
