wuchong commented on issue #9396: [FLINK-13473][table] Add stream Windowed 
FlatAggregate support for blink planner
URL: https://github.com/apache/flink/pull/9396#issuecomment-519769654
 
 
   I would suggest to modify the component name in commit message a bit. How 
about:
   
   [FLINK-13473][table-planner-blink] Support windowed TableAggregate in some 
MetadataHandle
   [FLINK-13473][table-runtime-blink] Add tests for window operator
   [FLINK-13473][table-blink] Add runtime support for windowed flatAggregat on 
blink planner
   [FLINK-13473][table-planner-blink] Add plan support for windowed 
flatAggregate on blink planner
   
   And for the pull request title, I would suggest to use "[table-blink]" 
because it doesn't contain API changes. 
   
   What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


With regards,
Apache Git Services

Reply via email to