JingsongLi commented on a change in pull request #9396:
[FLINK-13473][table-blink] Add stream Windowed FlatAggregate support for blink
planner
URL: https://github.com/apache/flink/pull/9396#discussion_r312506342
##########
File path:
flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/planner/codegen/agg/AggsHandlerCodeGenerator.scala
##########
@@ -866,10 +993,65 @@ class AggsHandlerCodeGenerator(
""".stripMargin
}
- private def genEmitValue(): String = {
+ private def genEmitValue(isWindow: Boolean = false): String = {
// validation check
checkNeededMethods(needEmitValue = true)
- aggBufferCodeGens(0).asInstanceOf[ImperativeAggCodeGen].emitValue
+ val methodName = "emitValue"
+ ctx.startNewLocalVariableStatement(methodName)
+
+ val windowCode =
+ if (isWindow) {
+ // no need to bind input
+ val exprGenerator = new ExprCodeGenerator(ctx, INPUT_NOT_NULL)
+ var valueExprs = Seq[GeneratedExpression]()
Review comment:
Just use `val valueExprs = getWindowExpressions(windowProperties)`? Because
`windowProperties` is empty when `hasNamespace` is false.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
