sunjincheng121 commented on a change in pull request #9396: [FLINK-13473][table-blink] Add stream Windowed FlatAggregate support for blink planner URL: https://github.com/apache/flink/pull/9396#discussion_r312684827
########## File path: flink-table/flink-table-runtime-blink/src/main/java/org/apache/flink/table/runtime/operators/window/AggregateWindowOperator.java ########## @@ -0,0 +1,186 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.flink.table.runtime.operators.window; + +import org.apache.flink.api.common.typeutils.TypeSerializer; +import org.apache.flink.api.java.functions.KeySelector; +import org.apache.flink.table.dataformat.BaseRow; +import org.apache.flink.table.dataformat.JoinedRow; +import org.apache.flink.table.dataformat.util.BaseRowUtil; +import org.apache.flink.table.runtime.generated.GeneratedNamespaceAggsHandleFunction; +import org.apache.flink.table.runtime.generated.GeneratedRecordEqualiser; +import org.apache.flink.table.runtime.generated.NamespaceAggsHandleFunction; +import org.apache.flink.table.runtime.generated.RecordEqualiser; +import org.apache.flink.table.runtime.operators.window.assigners.WindowAssigner; +import org.apache.flink.table.runtime.operators.window.triggers.Trigger; +import org.apache.flink.table.types.logical.LogicalType; + +import static org.apache.flink.util.Preconditions.checkNotNull; + +/** + * A {@link WindowOperator} that dedicates for group aggregate. + * + * <p>When an element arrives it gets assigned a key using a {@link KeySelector} and it gets Review comment: If we remove this paragraph, the next paragraph("Each pane gets its own instance...") would be hard to understand. Maybe we can keep this paragraph, or remove these two paragraphs in the base class? What do you think? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
