JingsongLi commented on a change in pull request #9433: [FLINK-13708]
[table-planner-blink] transformations should be cleared after execution in
blink planner
URL: https://github.com/apache/flink/pull/9433#discussion_r313770035
##########
File path:
flink-table/flink-table-planner-blink/src/test/scala/org/apache/flink/table/api/TableEnvironmentTest.scala
##########
@@ -18,11 +18,20 @@
package org.apache.flink.table.api
+import org.apache.flink.api.common.typeinfo.TypeInformation
+import org.apache.flink.api.common.typeinfo.Types.STRING
+import org.apache.flink.api.common.typeutils.TypeSerializer
import org.apache.flink.api.scala._
import org.apache.flink.streaming.api.environment.LocalStreamEnvironment
import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
+import org.apache.flink.table.api.internal.TableEnvironmentImpl
import org.apache.flink.table.api.scala.{StreamTableEnvironment, _}
-import org.apache.flink.table.planner.utils.TableTestUtil
+import org.apache.flink.table.planner.delegation.PlannerBase
+import org.apache.flink.table.planner.sinks.{CollectRowTableSink,
CollectTableSink}
+import org.apache.flink.table.planner.utils.{TableTestUtil, TestTableSources}
+import
org.apache.flink.table.types.utils.TypeConversions.fromDataTypeToLegacyInfo
+import org.apache.flink.types.Row
+import org.apache.flink.util.AbstractID
import org.apache.calcite.plan.RelOptUtil
import org.junit.Assert.assertEquals
Review comment:
Looks like `TableEnvironmentTest` is a planner tester. Why not extends
`TableTestBase`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services