[ 
https://issues.apache.org/jira/browse/FLINK-13692?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16907080#comment-16907080
 ] 

vinoyang commented on FLINK-13692:
----------------------------------

{{CompletedCheckpointStore#getLatestCheckpoint}} is not directly faced to the 
application users and is not marked at {{@public}} annotation. Therefore, I 
have no strong desire to maintain compatibility. However, we can also keep 
compatible with the old version for the convenience of the user.

> Make CompletedCheckpointStore backwards compatible?
> ---------------------------------------------------
>
>                 Key: FLINK-13692
>                 URL: https://issues.apache.org/jira/browse/FLINK-13692
>             Project: Flink
>          Issue Type: Bug
>          Components: Runtime / Checkpointing
>    Affects Versions: 1.9.0, 1.10.0
>            Reporter: Till Rohrmann
>            Priority: Major
>             Fix For: 1.10.0, 1.9.1
>
>
> With FLINK-11159 we changed the signature of 
> {{CompletedCheckpointStore#getLatestCheckpoint}} from 
> {{getLatestCheckpoint()}} to {{getLatestCheckpoint(boolean)}}. This is an API 
> breaking change which causes users of this interface having to adapt their 
> implementation and recompile it. Since {{CompletedCheckpointStore}} is no 
> public API, this change is technically ok, but not so nice. 
> If we decide to provide backwards compatibility, then we should still keep 
> {{getLatestCheckpoint()}} and add a deprecation annotation to it. At least, 
> we should update the JavaDocs of the 
> {{CompletedCheckpointStore#getLatestCheckpoint}} method to reflect what the 
> passed parameter states.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to