Github user gyfora commented on the pull request:
https://github.com/apache/flink/pull/1201#issuecomment-144765512
Looks good, my only concern is that it is getting messy with a new
Timestamp extractor interface as we already have one simply called Timestamp in
the windowing.helper package.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---