tillrohrmann commented on a change in pull request #9147: [FLINK-11631][test]
Harden TaskExecutorITCase
URL: https://github.com/apache/flink/pull/9147#discussion_r314232588
##########
File path:
flink-runtime/src/main/java/org/apache/flink/runtime/minicluster/MiniCluster.java
##########
@@ -230,6 +231,18 @@ public HighAvailabilityServices
getHighAvailabilityServices() {
}
}
+ @VisibleForTesting
+ @Nonnull
+ protected Map<ResourceID, TaskExecutor> getTaskManagers() {
+ return taskManagers;
+ }
+
+ @VisibleForTesting
+ @Nonnull
+ protected Object getManipulationLock() {
+ return lock;
+ }
Review comment:
This we should definitely not do. This leaks the internal implementation
details of this class to its sub classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
