zentol commented on a change in pull request #9258: [FLINK-13460][tests] Rework
SerializedThrowableTest to not use Unsafe#defineClass()
URL: https://github.com/apache/flink/pull/9258#discussion_r314258329
##########
File path:
flink-test-utils-parent/flink-test-utils-junit/src/main/java/org/apache/flink/core/testutils/CommonTestUtils.java
##########
@@ -159,14 +159,14 @@ public static void setEnv(Map<String, String> newenv,
boolean clearExisting) {
/**
* A new object and the corresponding ClassLoader for that object, as
returned by
- * {@link #createObjectFromNewClassLoader(ClassLoader)}.
+ * {@link #createSerializableObjectFromNewClassLoader(ClassLoader)}.
Review comment:
note that I don't see the benefit in either of them. changing the signature
of ´createSerializableObjectFromNewClassLoader` is basically a no-op, while
changing `ObjectAndClassLoader` just makes it more restrictive without a
benefit.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
