AHeise commented on a change in pull request #9383: [FLINK-13248] [runtime]
Adding processing of downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#discussion_r314300937
##########
File path:
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/mailbox/TaskMailboxImpl.java
##########
@@ -251,4 +280,79 @@ public void quiesce() {
public State getState() {
return state;
}
+
+ @Override
+ public Mailbox getDownstreamMailbox(AbstractStreamOperator<?> operator)
{
+ return
getDownstreamMailbox(operator.getOperatorConfig().getChainIndex());
Review comment:
That's what I had in the first place.
However, in respect to a possible branched operator chain (Piotr mentioned
that this may come), I wanted to make the priority and its type an
implementation detail.
Nevertheless, I see your point about the cyclic coupling and would revert
back to int priority.
Alternatively, we could also take the StreamConfig to avoid the cyclic
dependency graph.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
