AHeise commented on issue #9383: [FLINK-13248] [runtime] Adding processing of 
downstream messages in AsyncWaitOperator's wait loops
URL: https://github.com/apache/flink/pull/9383#issuecomment-521637692
 
 
   > You are removing the `ExecutorService` from the `MailboxExecutorImpl` 
implementation in the last commit.
   > Are there any limitations/reasons to do so?
   > 
   > Initially, this functionality was added for convenience to have futures 
that result with a mailbox letter.
   > So far, this was used for checkpoints triggers via mailbox (in a different 
branch, that not PRed yet)
   
   The basic idea of removing the ExecutorService interface is to get rid of 
the life-cycle methods. Since each Mailbox view is wrapped into an 
MailboxExecutor, each Mailbox view would also need to have life-cycle methods, 
which is a total mess.
   
   Instead, we just support the Executor interface, which is enough to support 
the nice CompletableFuture usages.
   The MailboxProcessor will then invoke the life-cycle methods on TaskMailbox, 
both are owned by the task.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to