zentol commented on a change in pull request #9386: [FLINK-13601][tests] Harden
RegionFailoverITCase by recording info when checkpoint just completed
URL: https://github.com/apache/flink/pull/9386#discussion_r314685717
##########
File path:
flink-tests/src/test/java/org/apache/flink/test/checkpointing/RegionFailoverITCase.java
##########
@@ -102,8 +111,14 @@
@Before
public void setup() throws Exception {
+ HighAvailabilityServicesUtilsTest.TestHAFactory.haServices =
new TestingHaServices(
Review comment:
please don't re-use the TestHAFactory class; with it's static mutable field
it should be avoided if possible.
You can just define your own `HighAvailabilityServicesFactory` with a lambda
`HighAvailabilityServicesFactory haServiceFactory = (config, executor) ->
new TestingHaServices...`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
