[
https://issues.apache.org/jira/browse/FLINK-13305?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16908997#comment-16908997
]
Chesnay Schepler edited comment on FLINK-13305 at 8/16/19 11:55 AM:
--------------------------------------------------------------------
The only proper solution I see is to rework the YARN headers to proper
MessageHeaders, i.e., extend the JobCancellationHeaders and override fields if
necessary.
We shouldn't add support for RestHandlerSpecification because we wouldn't be
able to document parameters in any way; the RHS was IIRC only added to support
the StaticFileServerHandler, which we don't want to be documented.
Similarly, we can't based the generation on the actual headers passed to the
handlers, because we unfortunately we've opted for an incredibly hacky approach
where a handler is given one header, but is registered under another. This
should very much be avoided, as it implies that the handler can no longer make
safe assumption over what input it actually receives.
was (Author: zentol):
The only proper solution I see is to rework the YARN headers to proper
MessageHeaders, i.e. ,by extend the JobCancellationHeaders and override fields
if necessary).
We shouldn't add support for RestHandlerSpecification because we wouldn't be
able to document parameters in any way; the RHS was IIRC only added to support
the StaticFileServerHandler, which we don't want to be documented.
Similarly, we can't based the generation on the actual headers passed to the
handlers, because we unfortunately we've opted for an incredibly hacky approach
where a handler is given one header, but is registered under another. This
should very much be avoided, as it implies that the handler can no longer make
safe assumption over what input it actually receives.
> YARN rest commands not documented
> ---------------------------------
>
> Key: FLINK-13305
> URL: https://issues.apache.org/jira/browse/FLINK-13305
> Project: Flink
> Issue Type: Bug
> Components: Documentation, Runtime / REST
> Affects Versions: 1.8.1, 1.9.0
> Reporter: Chesnay Schepler
> Priority: Major
>
> The YARN stop/cancel commands aren't documented. The generated excludes them
> since the headers don't implement the {{MessageHeaders}} interface.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
