tillrohrmann commented on a change in pull request #9456: FLINK-13588 
flink-streaming-java don't throw away exception info in logging 
URL: https://github.com/apache/flink/pull/9456#discussion_r314705802
 
 

 ##########
 File path: 
flink-streaming-java/src/main/java/org/apache/flink/streaming/runtime/tasks/AsynchronousException.java
 ##########
 @@ -38,6 +38,10 @@ public AsynchronousException(String message, Throwable 
cause) {
 
        @Override
        public String toString() {
-               return "AsynchronousException{" + getCause() + "}";
+               if (getMessage() != null) {
+                       return "AsynchronousException{" + getMessage() + ", 
caused by " + getCause() + "}";
+               } else {
+                       return "AsynchronousException{" + getCause() + "}";
+               }
 
 Review comment:
   I'd be in favour of simply removing the `toString` method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


With regards,
Apache Git Services

Reply via email to