[ 
https://issues.apache.org/jira/browse/FLINK-12514?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16909072#comment-16909072
 ] 

Piotr Nowojski commented on FLINK-12514:
----------------------------------------

I've briefly checked your PR and it's adding even more locking. I think 
whatever we do about this feature, it has to be done after refactoring 
FLINK-13698 and fixing bugs like FLINK-13497 caused by  FLINK-12364.

Can you also add better description in this ticket, what this change is about 
(what is it trying to fix/improve)? Also I think the title is misleading, as 
this is not a refactor, but a new feature.

> Refactor the failure checkpoint counting mechanism with ordered checkpoint id
> -----------------------------------------------------------------------------
>
>                 Key: FLINK-12514
>                 URL: https://issues.apache.org/jira/browse/FLINK-12514
>             Project: Flink
>          Issue Type: Improvement
>          Components: Runtime / Checkpointing
>            Reporter: vinoyang
>            Assignee: vinoyang
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> Currently, the checkpoint failure manager uses a simple counting mechanism 
> which does not tract checkpoint id sequence.
> However, a more graceful counting mechanism is based on ordered checkpoint id 
> sequence.
> It should be refactored after the FLINK-12364 would been merged.



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to